Open
Conversation
Collaborator
|
If you are a git user couldn't you dispense with this script and just do a "git pull" from the directory where BOSL2 is installed? |
Author
|
This script also tries to find the OpenSCAD plugin directory and does the initial The script could be modified to download/unzip the repo tarball, but I think there's a small space between "knows how to copy-paste a one-line script into the shell" and "has git". |
Collaborator
|
This needs a .MSI file to fetch and install the repo on Windows systems. Also, the README needs to explain installation on Windows using the .MSI installer file, and it needs to explain curl and git installation on both Linux (apt-get, dnf, etc) and MacOS (brew install) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a script for Git-users that finds the library path (if
openscadis on$PATHas a command), or guesses what it should be based on the OS, thengit clones orpulls into the appropriate directory.Skips the zip download, extract, renaming, finding the library path, moving.
The link in the README obviously doesn't work pre-merge, but you could look at it in the PR branch here: https://raw.githubusercontent.com/nicktimko/BOSL2/refs/heads/installer-script/get_bosl2.sh
Example run: